use new llvm pass manager instead of legacy pass manager #1963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use PassBuilder default -Ox passes instead of manually specifying passes - remove LLVMVisitor::init() overloads with explicit list of passes - add `passes` to SYMENGINE_LLVM_COMPONENTS in CMakeLists - increase minimum required llvm version to 4.0 - remove llvm from USE_GLIBCXX_DEBUG ci job - using debug libstdc++ changes the ABI: https://gcc.gnu.org/onlinedocs/libstdc++/manual/debug_mode_using.html - but llvm library is not compiled against debug libstdc++ - vector is passed between debug and non-debug translation units -> crash
isuruf
reviewed
Apr 28, 2023
Co-authored-by: Isuru Fernando <isuruf@gmail.com>
isuruf
approved these changes
Apr 28, 2023
|
I think this looks great! |
|
Thanks for the reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: https://llvm.org/docs/NewPassManager.html#status-of-the-new-and-legacy-pass-managers
PassBuilderdefault-O0,-O1, ... passes instead of manually specifying passesLLVMVisitor::init()overloads with explicit list of passespassesto SYMENGINE_LLVM_COMPONENTS in CMakeLists