Skip to content

In subs, check if coeff is a number and use a faster code path #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 28, 2023
Merged

In subs, check if coeff is a number and use a faster code path #1962

merged 5 commits into from
Mar 28, 2023

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Mar 27, 2023

Also fixes #1961

@isuruf isuruf requested a review from a team March 27, 2023 23:41
rikardn
rikardn approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@rikardn rikardn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@bjodah
Copy link
Contributor

bjodah commented Mar 28, 2023

looks great!

@isuruf
Copy link
Member Author

isuruf commented Mar 28, 2023

Thanks for the reviews

@isuruf isuruf merged commit bb26d60 into symengine:master Mar 28, 2023
@isuruf isuruf deleted the subs_complex_coeff branch April 15, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikardn rikardn rikardn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected floating-point differences evaluating subs on Mul involving complex floats
3 participants
@isuruf @bjodah @rikardn