add support for LLVM 16 #1954
Merged
add support for LLVM 16 #1954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- requires C++17 - `getBasicBlockList()` is now private but they provide an `insert()` method - requires CMake policy `CMP0057` (IN_LIST if() operator)
isuruf
approved these changes
Mar 14, 2023
|
I believe boost will soon also require C++17 (can't remember if it was 1.82 or 1.83 and exactly what modules will be affected), maybe we should switch the default even? (but keep some test configurations duing CI which explicitly uses -std=c++14) |
|
I can vote for switching the default to C++17. (I'd even vote for C++20 because modules are awesome) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getBasicBlockList()is now private but they provide aninsert()methodCMP0057(IN_LIST if() operator)