Use the correct free function when printing GMP numbers #1940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikardn
reviewed
Nov 17, 2022
| @@ -123,9 +124,11 @@ inline void mp_set_str(integer_class &i, const std::string &a) | |||
|
|
|||
| inline std::string mp_get_hex_str(const integer_class &i) | |||
| { | |||
| void (*freefunc)(void *, size_t); | |||
| mp_get_memory_functions(NULL, NULL, &freefunc); | |||
There was a problem hiding this comment.
Is this needed? Would mpz_clear not use any custom deallocator?
There was a problem hiding this comment.
I believe mpz_clear is only for mpz_t instances, because mpz seems to want to track how much memory was allocated/freed.
https://gmplib.org/manual/Converting-Integers and https://gmplib.org/manual/Custom-Allocation.
It might work, but I'm not sure how correct it would be, since they go through different paths inside of gmp.
https://github.com/alisw/GMP/blob/2bbd52703e5af82509773264bfbd20ff8464804f/gmp-impl.h#L715-L716
There was a problem hiding this comment.
Sorry I misunderstood the situation. This is for the string allocation not for mpz_t
isuruf
approved these changes
Nov 18, 2022
rikardn
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GMP supports custom allocators so the correct thing is to respect their allocation functions