Support of Piecewise in parser #1882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjodah
commented
Feb 8, 2022
There was a problem hiding this comment.
*outdated comment*
this is now accepted by the parser, but the dynamic cast too Boolean fails, I guess the parser is going bottom up and has a partial match on this argument since I added "epair" to the parser. Not sure how to constrain the parser. Add a designated token for Piecewise in the tokenizer?
8a0e76c to
d85b2b9
Compare
rikardn
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not working yet. Any feedback on approach/what's missing is of course much appreciated.OK, so tests pass locally. I had to add a token for
Piecewiseto special case the parsing of list-of-pairs. Let me know what you think.