Skip to content

Add logarithm power rule to refine #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2021
Merged

Add logarithm power rule to refine #1861

merged 1 commit into from
Nov 7, 2021

Conversation

rikardn
Copy link
Contributor

@rikardn rikardn commented Oct 29, 2021

log(x**y) -> x*log(y) if x > 0 and y real.

@rikardn rikardn requested a review from a team November 7, 2021 16:59
certik
certik approved these changes Nov 7, 2021
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that looks great.

In some sense, the refine is like a compiler optimization pass. If it knows how to optimize, it will do it, otherwise it will ignore it.

@rikardn
Copy link
Contributor Author

rikardn commented Nov 7, 2021

Thanks @certik for reviewing. I like the analogy

@rikardn rikardn merged commit ca3b3ba into symengine:master Nov 7, 2021
@rikardn rikardn deleted the logpower branch November 7, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rikardn @certik