First version of simplify #1831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any comments or are we ready to merge? |
isuruf
approved these changes
Oct 18, 2021
|
Thanks @isuruf for reviewing |
|
Why not implement all the functions similar to Sympy's simplify() function? In fact, algebraic simplification plays a crucial role in mathematical computations and analyses. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will first do
refineand then try more advanced simplifications. Started out with supportingy/csc(x) = y*sin(x)and similar.I encountered the issue of having to support both
PowandMulfor very similar situations. For example1 / xwill be aPowbut2 / xwill be aMul. Perhaps this would break too much and be a bad idea for other reasons, but in this scenario it would simplify things if also1 / xwould beMulwith coeff = 1. ThenMulwould cover all cases with numeric exponents and Pow wouldn't have to cater for these.