-
Notifications
You must be signed in to change notification settings - Fork 592
feat!: make backspace
command not close the input even when value is empty
#1680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Interesting. I'm having a similar issue: I'm using [[manager.prepend_keymap]]
on = ["<Backspace>"]
run = 'shell "kitten run-shell kitty @ set-tab-title "Yazi terminal" ; kitty @ set-tab-title "Yazi"" --block --confirm'
desc = "Open shell here" and when pressing This is annoying. |
Why not use yazi/yazi-config/preset/keymap.toml Lines 240 to 241 in 631afd0
It's a more convenient and direct way, so you don't have to keep hitting |
I'm aware of this binding but I'm just so used to |
I'm not always decide to delete all content when I start to delete them. Usually when I have deleted half of the content, I realized the rest of them is wrong too, so I'll keep |
I just got another report about this issue: #1681. It seems like enough people are bothered by this behavior, so I think we can just remove it since it's a breaking change anyway, and it's also hard to come up with a way (like warnings) to prompt users with the existing |
What about change this option to |
No, just remove it - if enough people are bothered by it, then its worth breaking. I'll also keep this PR open for a while to see if there are any differing opinions |
backspace
command not close the input even when value is empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.