hygiene: handle use-use conflict #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 21, 2020
Kind indicates type of identifier. hygiene pass tracks it to preserve ident renaming rule.
It means,
```js
export function foo() {
console.log(i18n(_templateObject()));
console.log(i18n(_templateObject()));
console.log(i18n(_templateObject()));
}
```
should be
```js
export function foo() {
console.log(i18n(_templateObject()));
console.log(i18n(_templateObject1()));
console.log(i18n(_templateObject2()));
}
```
Closes #598
Build failed
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind indicates the type of identifier. Note that as we don't care about emitting a clean code, the renamed output may not match it of bind-bind conflict or bind-use conflict.
Closes #598