Skip to content

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 23, 2022

Description:

swc_ecma_minifier:

  • Don't negate a if statement if it has let/const binding.

Related issue (if exists):

@kdy1 kdy1 added this to the v1.2.134 milestone Jan 23, 2022
@kdy1 kdy1 changed the title fix(es/minifier): Don't merge const/let into narrower scope. fix(es/minifier): Don't merge const/let into narrower scope Jan 23, 2022
@kdy1 kdy1 changed the title fix(es/minifier): Don't merge const/let into narrower scope fix(es/minifier): Fix a bug Jan 23, 2022
@kdy1 kdy1 changed the title fix(es/minifier): Fix a bug fix(es/minifier): Respect block scoping while negating if statements Jan 23, 2022
@kdy1 kdy1 marked this pull request as ready for review January 23, 2022 15:19
@kdy1 kdy1 merged commit 6921ffb into swc-project:main Jan 23, 2022
@kdy1 kdy1 deleted the minifier-feedback-3 branch January 23, 2022 15:19
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Jan 24, 2022
This PR applies

 - swc-project/swc#3344

Resolves #30237 (comment)

 - swc-project/swc#3348

 - swc-project/swc#3352

This fixes `jsc.experimental.keepImportAssertions`.
@kdy1 kdy1 modified the milestones: v1.2.134, v1.2.135 Jan 25, 2022
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
This PR applies

 - swc-project/swc#3344

Resolves vercel#30237 (comment)

 - swc-project/swc#3348

 - swc-project/swc#3352

This fixes `jsc.experimental.keepImportAssertions`.
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant