Skip to content

Conversation

kakwa
Copy link
Contributor

@kakwa kakwa commented Aug 16, 2022

Describe the PR

Expose the syntax highlighting enable/disable option from swagger UI.

This PR sets the default value at true, retaining the current behavior if the option is not set.

Relation issue
N/A

Additional context
Exposing this option is necessary when dealing with large payload, otherwise, the syntax highlighting hangs swagger ui.

https://stackoverflow.com/questions/63615230/swagger-ui-hangs-on-big-responses

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #91 (8bb5e81) into master (717c612) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #91   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           78        82    +4     
=========================================
+ Hits            78        82    +4     
Impacted Files Coverage Δ
swagger.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit 7531e85 into swaggo:master Aug 17, 2022
@ubogdan
Copy link
Contributor

ubogdan commented Aug 17, 2022

@kakwa Thanks for your contribution!

@kakwa
Copy link
Contributor Author

kakwa commented Aug 17, 2022

@ubogdan you're welcome, thanks for merging the PR quickly ^^.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants