add better support for validation groups #4853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdi
reviewed
Mar 11, 2025
| method.invoke(swaggerLoader, validatorProcessorClass.get()); | ||
| } | ||
|
|
||
| if (defaultResponseCode.isPresent() && StringUtils.isNotBlank(groupsValidationStrategy.get())) { |
There was a problem hiding this comment.
A bug has been introduced on this line, see #4858.
This was referenced Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #4804 and replaces #4797, #4246 and #4805 by changing default behavior to only add by default validation when no groups are specified or when they match "context" groups (e.g. specified via Spring
Validatedannotation orValidatedParameternew annotation)It also introduces new configuration fields
groupsValidationStrategyandvalidatorProcessorClasswhich allow to tweak resolution of validation constraints, see tests in this PR and upcoming wiki update for usage scenarios.Previous behavior (resolving validation constraints regardless of groups) can be accomplished by passing new configuration property
groupsValidationStrategy=always