Skip to content
This repository was archived by the owner on Dec 28, 2024. It is now read-only.

Conversation

svix-lucho
Copy link
Contributor

  • Upgrade svix-webhooks to 1.7.0. Add context parameter in all calls since it's now required by the svix client.

  • Fix default endpoint version. The default value for endpoint version flag was 0, causing the cli to make an invalid request (422) when trying to create an endpoint without the version flag (svix create endpoint --data-url https://example.com).

Screenshot 2023-07-31 at 5 25 09 PM

@svix-lucho svix-lucho self-assigned this Jul 31, 2023
svix-onelson
svix-onelson previously approved these changes Aug 2, 2023
Copy link
Contributor

@svix-onelson svix-onelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me. We probably don't need to make a decision about the ctx right now, but wanted to raise the issue.

Copy link
Contributor

@svix-onelson svix-onelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@svix-lucho svix-lucho merged commit a91eae1 into main Aug 3, 2023
@svix-lucho svix-lucho deleted the lucho/bump-libs-fix-version branch August 3, 2023 20:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants