This repository was archived by the owner on Dec 28, 2024. It is now read-only.
Remove reconnection interval and prevent hanging #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fcjr -- if you remember why this was included in the first place, I'd greatly appreciate the insight. If it was there for a good reason, I don't want to remove it. But, testing these changes, the connection will easily last 30+ minutes without any issue when it would regularly fail within 10 minutes when frequently reconnecting. |
Use `stopRead` and `stopWrite` channels to communicate with sender / receive loops about . If channel close is initiated, as indicated by a message to `stopRead` or `stopWrite`, don't send errors on the error channel, which won't be read at that point anyway. Furthermore, add a small amount of buffering to the channels just to avoid possibility that a single message could inadvertently cause blocking.
svix-james
approved these changes
Feb 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two bugs had been noticed, both with the automatic reconnection interval (where it would forcibly close the connection and reconnect every minute) as the primary cause.
Upon reconnection, the text that prints when you first start the tool in
listenmode would reprint causing the logs to be filled with the same connection message many times.Additionally, there is an issue in the concurrency where, on seemingly random occasions, the program would hang after disconnecting but before reconnecting due to a closed channel.
Finally, changes were made to the channels to avoid potential hanging on channel closure.
By removing this interval and by preventing hanging the reconnection-based bugs should at the very least become much more rare.