This repository was archived by the owner on Dec 28, 2024. It is now read-only.
Attempt fixing error in Svix Play listen mode #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasn
approved these changes
Aug 26, 2022
Merged
tasn
pushed a commit
that referenced
this pull request
Aug 26, 2022
Update the changelog to include the patch in #81
svix-daniel
pushed a commit
that referenced
this pull request
Jan 31, 2023
svix-daniel
added a commit
that referenced
this pull request
Jan 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On occasion the listen command would fail to reconnect to the Play server and instead hang. This change attempts to fix that by making sure the socket read and write tasks shutdown before the connection is broken.