Skip to content

fix: ensure static error page is loaded correctly for custom user errors #13952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 20, 2025
Merged

fix: ensure static error page is loaded correctly for custom user errors #13952

merged 4 commits into from
Aug 20, 2025

Conversation

rChaoz
Copy link
Contributor

@rChaoz rChaoz commented Jul 3, 2025

Closes #13951

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 3, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: ff1efc4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

benmccann
benmccann reviewed Jul 3, 2025
View reviewed changes
@rChaoz rChaoz changed the title Fix/static error page typeerror Fix static error page typeerror Jul 5, 2025
@rChaoz rChaoz requested a review from benmccann July 5, 2025 21:40
@eltigerchino eltigerchino changed the title Fix static error page typeerror fix: ensure static error page is loaded correctly for custom user errors Jul 8, 2025
@svelte-docs-bot
Copy link

Preview: https://svelte-dev-git-preview-kit-13952-svelte.vercel.app/

Rich-Harris
Rich-Harris approved these changes Aug 20, 2025
View reviewed changes
Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@Rich-Harris Rich-Harris merged commit bfa3b9c into sveltejs:main Aug 20, 2025
18 checks passed
@github-actions github-actions bot mentioned this pull request Aug 20, 2025
Merged
@rChaoz rChaoz deleted the fix/static-error-page-typeerror branch August 20, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rich-Harris Rich-Harris Rich-Harris approved these changes

@benmccann benmccann Awaiting requested review from benmccann

Assignees
No one assigned
Labels
error handling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'replace') at escape_html
3 participants
@rChaoz @benmccann @Rich-Harris