fix: omit stack when logging 404 errors #13848
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspired by #13830, but separate: it makes no sense to log a stack trace with a 404, we can just log
Not found: /blah
. The stack trace will only ever include SvelteKit internals, there's nothing that a developer can do with that information.We could probably improve logging of server-side errors all round (e.g. a nicely formatted
[500] GET /whatever
with a sanitized stack trace, maybe a code frame if appropriate, maybe opening a model on the client, etc) but I thought it would make sense to start with this no-brainer PRPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits