Skip to content

Conversation

Rich-Harris
Copy link
Member

inspired by #13830, but separate: it makes no sense to log a stack trace with a 404, we can just log Not found: /blah. The stack trace will only ever include SvelteKit internals, there's nothing that a developer can do with that information.

We could probably improve logging of server-side errors all round (e.g. a nicely formatted [500] GET /whatever with a sanitized stack trace, maybe a code frame if appropriate, maybe opening a model on the client, etc) but I thought it would make sense to start with this no-brainer PR


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jun 2, 2025

🦋 Changeset detected

Latest commit: cb264ba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this. it'd be nice to do it in prod too

@Rich-Harris
Copy link
Member Author

The changeset was mistaken — this does apply in prod as well, they go through the same code

@Rich-Harris Rich-Harris merged commit e16b7e6 into main Jun 3, 2025
13 of 16 checks passed
@Rich-Harris Rich-Harris deleted the omit-stack-on-404 branch June 3, 2025 14:44
@benmccann benmccann changed the title fix: omit stack when logging 404 errors in dev fix: omit stack when logging 404 errors Jun 3, 2025
@github-actions github-actions bot mentioned this pull request Jun 3, 2025
@benmccann benmccann mentioned this pull request Jul 16, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants