fix: serialize server load data before passing to universal load alternative
#14298
Conversation
🦋 Changeset detectedLatest commit: 530de88 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Finally all green. |
|
Please resist the temptation to make drive-by tidy-ups, especially ones as large as these! It drowns out the substance of the PR and makes it much harder to understand what has actually changed. My tendency as a reviewer is to put PRs with large diffs in the 'ugh... later' pile, and I suspect a lot of maintainers are the same way. Now that I've reverted all those changes I can get to work on the actual review :) |
|
Sorry, it wasn't a temptation, it happened automatically on save. I usually undo these myself before committing, must have forgotten. |
|
Ah, interesting. FWIW they were good changes — the imports are very raggedy. Would just be nice to update them all en masse (and maybe add similar tooling to keep them organised afterwards), once there are no open PRs that doing so would create merge conflicts with |
|
Nice solution for that nonce thing |
Alternative to #14268
Fixes #14291
CC @Rich-Harris
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits