Skip to content

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Aug 19, 2025

fixes #13428

This PR ensures the app variable is available when the server pushes chunks to the client to decode custom data types as they stream in. This fixes streaming for split and single apps by wrapping the code that references app after an import statement, and providing the correct global variable for inline apps.

An additional test suite for inline apps has also been added since none existed before. However, feel free to remove it if it's too much just to test inline apps.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Aug 19, 2025

🦋 Changeset detected

Latest commit: 23af149

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@eltigerchino eltigerchino marked this pull request as ready for review August 20, 2025 06:21
@Rich-Harris
Copy link
Member

golfed it a little bit so that we don't need to repeat the import, by passing a callback to resolve

@Rich-Harris Rich-Harris merged commit 69b6384 into main Aug 20, 2025
21 checks passed
@Rich-Harris Rich-Harris deleted the fix-transport-stream branch August 20, 2025 20:16
@github-actions github-actions bot mentioned this pull request Aug 20, 2025
@eltigerchino
Copy link
Member Author

golfed it a little bit so that we don't need to repeat the import, by passing a callback to resolve

Nice! Thanks for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When streaming a promise from load that returns an object requiring serialization through transport. Uncaught ReferenceError: app is not defined ocurs
2 participants