-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: deserialise streamed custom types #14261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 23af149 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
golfed it a little bit so that we don't need to repeat the import, by passing a callback to |
Nice! Thanks for that |
fixes #13428
This PR ensures the
app
variable is available when the server pushes chunks to the client to decode custom data types as they stream in. This fixes streaming for split and single apps by wrapping the code that referencesapp
after an import statement, and providing the correct global variable for inline apps.An additional test suite for inline apps has also been added since none existed before. However, feel free to remove it if it's too much just to test inline apps.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits