Skip to content

chore: update link to Workers Sites section #14237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2025
Merged

chore: update link to Workers Sites section #14237

merged 2 commits into from
Aug 20, 2025
+6 −1

Conversation

kevinji
Copy link
Contributor

@kevinji kevinji commented Aug 16, 2025

The section title has change a bit, so the original link no longer goes to the section.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: cb2ca92

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Preview: https://svelte-dev-git-preview-kit-14237-svelte.vercel.app/

@kevinji kevinji changed the title chore(adapter-cloudflare): update link to Workers Sites section chore: update link to Workers Sites section Aug 16, 2025
@eltigerchino eltigerchino added documentation Improvements or additions to documentation pkg:adapter-cloudflare labels Aug 19, 2025
eltigerchino
eltigerchino approved these changes Aug 19, 2025
View reviewed changes
Copy link
Member

@eltigerchino eltigerchino left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is a nice catch.

Could you generate a changeset for this? It should be a patch since we're just changing an error message.

If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@eltigerchino eltigerchino removed the documentation Improvements or additions to documentation label Aug 19, 2025
@kevinji
Copy link
Contributor Author

kevinji commented Aug 20, 2025

Done! Wasn't sure if this needed a changeset since it was just a link fix.

eltigerchino
eltigerchino reviewed Aug 20, 2025
View reviewed changes
eltigerchino
eltigerchino approved these changes Aug 20, 2025
View reviewed changes
Copy link
Member

@eltigerchino eltigerchino left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think the general rule is that if we want people to receive a change, then we need a changeset so we can release a new version.

@eltigerchino eltigerchino merged commit 848b4cb into sveltejs:main Aug 20, 2025
18 checks passed
@github-actions github-actions bot mentioned this pull request Aug 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eltigerchino eltigerchino eltigerchino approved these changes

Assignees
No one assigned
Labels
pkg:adapter-cloudflare
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinji @eltigerchino