Skip to content

Implement instant_print_lines argument #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 10, 2023
Merged

Implement instant_print_lines argument #583

merged 6 commits into from
Dec 10, 2023

Conversation

josherrickson
Copy link
Contributor

Addresses #582; adding functionality to remove any time-delay in printing the first n number of lines.

Copy link
Owner

@svenstaro svenstaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first contribution! A few nitpicks but the overall concept looks sound!

@svenstaro
Copy link
Owner

Could you also rebase to get rid of the merge commit into your branch?

@josherrickson
Copy link
Contributor Author

I've added wasm32 support. I also rebased.

PS I picked instant-print-lines just to avoid -q, but I suppose -i isn't much better - let me know if you'd prefer I use quickstart or something else.

@svenstaro
Copy link
Owner

Great work! Not bad for your first Rust contribution. :)

@svenstaro svenstaro merged commit 91b1b30 into svenstaro:master Dec 10, 2023
svenstaro added a commit that referenced this pull request Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants