Pass "npm run all", locally + in CI #137
Conversation
yairm210
commented
Jun 11, 2025
- Reduce @octokit/core version to one compatible with @actions/github, which is what actually provides the Octokit instance, so we can type things with it and tsc doesn't complain (it's only for typing anyway)
- Convert eslint to the new format according to this guide
- Added some ignore signals to tsc so it doesn't break on response types returned as generic and converted to specific
|
I see E2E tests fail on PRs, because they can't create a release - makes sense, that's a restricted action |
| @@ -1,5 +1,5 @@ | |||
| name: "CI" | |||
| on: [pull_request, push] | |||
| on: [pull_request, push, workflow_dispatch] | |||
There was a problem hiding this comment.
So I can test things if CI fails on flaky things
There was a problem hiding this comment.
On second thought I could just 'retry'... Removable
There was a problem hiding this comment.
Ah, I see. Well, if it makes that easier for you, feel free to leave it in by I usually just retry it.
There was a problem hiding this comment.
Please rebase this so that we don't have a commit adding and then removing it.
There was a problem hiding this comment.
Reverted, in any case I think this should be squash-merged 🤔
| @@ -38,6 +38,8 @@ async function get_release_by_tag( | |||
| let release: ReleaseByTagResp | |||
| try { | |||
| core.debug(`Getting release by tag ${tag}.`) | |||
|
|
|||
| // @ts-ignore | |||
There was a problem hiding this comment.
Isn't there a better way than just ignoring these?
There was a problem hiding this comment.
Not that I found... I could "as object as resulttype", but I think that's just as bad :/
There was a problem hiding this comment.
Alright, that's unfortunate but I have no better idea either.
|
After doing the rebase, feel free to merge. |
|
Security warnings went from 7 to 1 👍🏿 |