Skip to content

Addition of configuration file option #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 28, 2020
Merged

Addition of configuration file option #74

merged 8 commits into from
Sep 28, 2020

Conversation

Cyb3r-Jak3
Copy link
Contributor

@Cyb3r-Jak3 Cyb3r-Jak3 commented Sep 27, 2020 •
edited
Loading

Notable Changes:

  • Creates --config option for use of YAML config file
    • Creates tests for config option
  • Updates vunjar to 20.6.30
  • Drops 3.4 support as it is not supported by PyYAML
  • Adds 3.8 support

@Cyb3r-Jak3 Cyb3r-Jak3 changed the title Addition of configuration file Addition of configuration file option Sep 27, 2020
@svenkreiss
Copy link
Owner

Thanks! This looks good to me.

This also adds --log-file. Did you come across a use-case where this is better than the previous unix command that you had?

@Cyb3r-Jak3
Copy link
Contributor Author

--log-file is a better solution for windows as I do not know a way to use |& tee in Powershell.

@svenkreiss
Copy link
Owner

Indeed. Great. Going to merge this now. Thanks again!

@svenkreiss svenkreiss merged commit 6afe576 into svenkreiss:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cyb3r-Jak3 @svenkreiss