Switched from check_output to Popen #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

svenkreiss merged 4 commits into svenkreiss:master from Cyb3r-Jak3:master

Oct 24, 2019

Contributor

Cyb3r-Jak3 commented Oct 24, 2019

Major Changes

Updates vnujar to 18.11.5 (Closes Update vnu.jar to latest version to fix issue with JSON output #55)
Changed subprocess from check_output to popen. (Should fix When using format json, always 1 is returned #52)

Minor Changes

Changed travis ci to have two seperate steps with the test
Adds the option to use stout from the process

Cyb3r-Jak3 added 4 commits

October 23, 2019 12:55


          Updated vnujar to 18.11.5

71c6436


          Fixed issues with format return issues.

af574de


          Fixing the test issues

43e5911


          Fixed all tests

0a46909

svenkreiss merged commit 5db4ffe into svenkreiss:master

Owner

svenkreiss commented Oct 24, 2019

Thank you! Very clean change. Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet