Skip to content

Log and return to ensure defers are still called in example dicomutil. #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2023
Merged

Log and return to ensure defers are still called in example dicomutil. #278

merged 2 commits into from
Jul 2, 2023

Conversation

suyashkumar
Copy link
Owner

Where appropriate, this calls log.Infof along with a return instead of log.Fatalf to ensure defered functions are actually run in those exit scenarios.

Looking at dicomutil, it could probably use some improvements and a refactor as well in general as an example program.

@suyashkumar suyashkumar mentioned this pull request Jul 2, 2023
Closed
@suyashkumar suyashkumar self-assigned this Jul 2, 2023
@suyashkumar suyashkumar changed the title Log and return to ensure defers are still called in dicomutil. Log and return to ensure defers are still called in example dicomutil. Jul 2, 2023
@suyashkumar suyashkumar merged commit 9612756 into main Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@suyashkumar suyashkumar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@suyashkumar