Skip to content

Add missing opts parameter to downstream call to write.Dataset #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2020
Merged

Add missing opts parameter to downstream call to write.Dataset #102

merged 1 commit into from
Jul 20, 2020

Conversation

courteouselk
Copy link
Contributor

Function write.DataSetToFile does not pass opts argument further down the line. This PR fixes this.

suyashkumar
suyashkumar approved these changes Jul 20, 2020
View reviewed changes
Copy link
Owner

@suyashkumar suyashkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@suyashkumar suyashkumar added the bug Something isn't working label Jul 20, 2020
@suyashkumar suyashkumar linked an issue Jul 20, 2020 that may be closed by this pull request
Incorrect error "VR value mismatch for tag (0028,0120)[PixelPaddingValue]. Element.VR=SS, but DICOM standard defines VR to be US" #91
Closed
@suyashkumar suyashkumar removed a link to an issue Jul 20, 2020
Incorrect error "VR value mismatch for tag (0028,0120)[PixelPaddingValue]. Element.VR=SS, but DICOM standard defines VR to be US" #91
Closed
@suyashkumar suyashkumar merged commit cbbb55d into suyashkumar:master Jul 20, 2020
@suyashkumar suyashkumar mentioned this pull request Jul 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyashkumar suyashkumar suyashkumar approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@courteouselk @suyashkumar