Skip to content

Conversation

mossheim
Copy link
Contributor

also recommend building supernova plugins

supercollider/supercollider#5159 (comment)

also recommend building supernova plugins
@redFrik
Copy link
Contributor

redFrik commented Sep 10, 2020

shouldn't you also mention that you also fixed Release mode build here? and warn about that any build prior (unsure for how long) might have been Debug?

@mossheim mossheim merged commit dd092a2 into supercollider:master Sep 10, 2020
@mossheim mossheim deleted the topic/readme branch September 10, 2020 14:28
@mossheim
Copy link
Contributor Author

no, we don't normally provide that level of detail in build instructions, and this would be a bad place to make that kind of announcement. however, i can let people know on the mailing list and forum.

@redFrik
Copy link
Contributor

redFrik commented Sep 10, 2020

no, not in the instructions themselves - i meant here on github or in the git commit message. the title "fix build instructions" is very vague and there wasn't a single mention of the (IMO) much bigger issue that you corrected - the debug vs release mode build.
yes please, some form of announcement on the mailing list would be good.

@mossheim
Copy link
Contributor Author

uhh, okay. i've sent out the announcement. changelog for the next release will include this PR.

@redFrik
Copy link
Contributor

redFrik commented Sep 10, 2020

great. thanks!

@mossheim
Copy link
Contributor Author

also added to the release info here: https://github.com/supercollider/sc3-plugins/releases/tag/Version-3.11.0. that page is linked from supercollider.github.io/sc3-plugins too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants