Skip to content

refactor(config): move metrics package to config #2201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

refactor(config): move metrics package to config #2201

merged 1 commit into from
Jul 7, 2025

Conversation

vimalk78
Copy link
Collaborator

@vimalk78 vimalk78 commented Jul 7, 2025

  • Move metrics level types from internal/exporter/prometheus/metrics to config package
  • Add MetricsLevelAll constant
  • Update imports
  • Update tesst

@vimalk78
refactor(config): move metrics package to config
ea7568e 
  - Move metrics level types from internal/exporter/prometheus/metrics to config package
  - Add MetricsLevelAll constant
  - Update imports
  - Update tesst

Signed-off-by: Vimal Kumar <vimal78@gmail.com>
@github-actions github-actions bot added the refactor Code refactoring without changing functionality label Jul 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

⚠️ Config changes detected in this PR.
Please make sure that the config changes are updated in the following places as part of this PR:

  • docs/configuration/configuration.md
  • compose/dev/kepler-dev/etc/kepler/config.yaml
  • hack/config.yaml
  • manifests/k8s/configmap.yaml

@codecov Codecov
Copy link

codecov bot commented Jul 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.25%. Comparing base (b611eea) to head (ea7568e).
Report is 2 commits behind head on reboot.

Files with missing lines Patch % Lines
internal/exporter/prometheus/prometheus.go 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           reboot    #2201   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files          38       38           
  Lines        3924     3924           
=======================================
  Hits         3620     3620           
  Misses        242      242           
  Partials       62       62

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sthaha sthaha merged commit 4a37dc7 into sustainable-computing-io:reboot Jul 7, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sthaha sthaha sthaha approved these changes

Assignees
No one assigned
Labels
refactor Code refactoring without changing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vimalk78 @sthaha