Skip to content

Conversation

sthaha
Copy link
Collaborator

@sthaha sthaha commented Jul 9, 2025

Add minimum energy threshold filtering for terminated workloads to improve tracking of workloads that are meaningful to the user. The terminated resource tracker now filters out low-energy workloads, keeping only those that consumed significant energy.

Side-effect: This reduces memory usage while maintaining tracking of relevant terminated resources.

Changes:

  • Add minTerminatedEnergyThreshold config option (default: 10 joules)
  • Modify TerminatedResourceTracker with energy-based filtering
  • Update configuration files for dev and k8s environments

Config example:

monitor:
  minTerminatedEnergyThreshold: 10  # joules

@github-actions github-actions bot added the feat A new feature or enhancement label Jul 9, 2025
Copy link
Contributor

github-actions bot commented Jul 9, 2025

⚠️ Config changes detected in this PR.
Please make sure that the config changes are updated in the following places as part of this PR:

  • docs/configuration/configuration.md
  • compose/dev/kepler-dev/etc/kepler/config.yaml
  • hack/config.yaml
  • manifests/k8s/configmap.yaml

Copy link

codecov bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 93.44262% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.27%. Comparing base (d7a013f) to head (700ea62).
Report is 3 commits behind head on reboot.

Files with missing lines Patch % Lines
internal/monitor/options.go 63.63% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           reboot    #2209      +/-   ##
==========================================
- Coverage   92.40%   92.27%   -0.13%     
==========================================
  Files          39       39              
  Lines        4159     4142      -17     
==========================================
- Hits         3843     3822      -21     
- Misses        253      257       +4     
  Partials       63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Add minimum energy threshold filtering for terminated workloads to improve
tracking of workloads that are meaningful to the user. The terminated resource
tracker now filters out low-energy workloads, keeping only those that
consumed significant energy.

Side-effect: This reduces memory usage while maintaining tracking of relevant
terminated resources.

Changes:
- Add minTerminatedEnergyThreshold config option (default: 10 joules)
- Modify TerminatedResourceTracker with energy-based filtering
- Update configuration files for dev and k8s environments

Config example:
```yaml
monitor:
  minTerminatedEnergyThreshold: 10  # joules
```

Signed-off-by: Sunil Thaha <sthaha@redhat.com>
@sthaha sthaha force-pushed the fix-terminated-min-power branch from 4276df0 to 508b726 Compare July 9, 2025 05:22
Copy link
Contributor

github-actions bot commented Jul 9, 2025

⚠️ Config changes detected in this PR.
Please make sure that the config changes are updated in the following places as part of this PR:

  • docs/configuration/configuration.md
  • compose/dev/kepler-dev/etc/kepler/config.yaml
  • hack/config.yaml
  • manifests/k8s/configmap.yaml

@sthaha sthaha marked this pull request as ready for review July 9, 2025 05:29
@sthaha sthaha requested review from vimalk78 and vprashar2929 July 9, 2025 05:29
@github-actions github-actions bot added the fix A bug fix label Jul 9, 2025
Copy link
Contributor

github-actions bot commented Jul 9, 2025

⚠️ Config changes detected in this PR.
Please make sure that the config changes are updated in the following places as part of this PR:

  • docs/configuration/configuration.md
  • compose/dev/kepler-dev/etc/kepler/config.yaml
  • hack/config.yaml
  • manifests/k8s/configmap.yaml

… tracking

Signed-off-by: Sunil Thaha <sthaha@redhat.com>
@sthaha sthaha force-pushed the fix-terminated-min-power branch from 9df2a36 to 700ea62 Compare July 9, 2025 06:09
Copy link
Contributor

github-actions bot commented Jul 9, 2025

⚠️ Config changes detected in this PR.
Please make sure that the config changes are updated in the following places as part of this PR:

  • docs/configuration/configuration.md
  • compose/dev/kepler-dev/etc/kepler/config.yaml
  • hack/config.yaml
  • manifests/k8s/configmap.yaml

@vprashar2929 vprashar2929 merged commit f7243fd into sustainable-computing-io:reboot Jul 9, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat A new feature or enhancement fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants