Skip to content

feat(config): add configurable web server listen addresses #2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2025
Merged

feat(config): add configurable web server listen addresses #2206

merged 1 commit into from
Jul 8, 2025

Conversation

sthaha
Copy link
Collaborator

@sthaha sthaha commented Jul 8, 2025

Add support for configurable listen addresses for the web server through both CLI flags and YAML configuration, instead of the hardcoded :28282 default. This change is needed to support a reverse proxy (kube-rbac-proxy) setup where the listen-address will use 127.0.0.1:28282 instead of 0.0.0.0:28282

Changes include:

  • Add Web.ListenAddresses []string field to config structure
  • Add --web.listen-address CLI flag (repeatable for multiple addresses)

@sthaha sthaha requested a review from vprashar2929 July 8, 2025 13:21
@github-actions github-actions bot added the feat A new feature or enhancement label Jul 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

⚠️ Config changes detected in this PR.
Please make sure that the config changes are updated in the following places as part of this PR:

  • docs/configuration/configuration.md
  • compose/dev/kepler-dev/etc/kepler/config.yaml
  • hack/config.yaml
  • manifests/k8s/configmap.yaml

@codecov Codecov
Copy link

codecov bot commented Jul 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.50%. Comparing base (4a37dc7) to head (c9d7667).

Additional details and impacted files 
@@            Coverage Diff             @@
##           reboot    #2206      +/-   ##
==========================================
+ Coverage   92.25%   92.50%   +0.25%     
==========================================
  Files          38       38              
  Lines        3924     3965      +41     
==========================================
+ Hits         3620     3668      +48     
+ Misses        242      237       -5     
+ Partials       62       60       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sthaha sthaha force-pushed the fix-server-address branch from 495124b to 91a97e3 Compare July 8, 2025 13:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

⚠️ Config changes detected in this PR.
Please make sure that the config changes are updated in the following places as part of this PR:

  • docs/configuration/configuration.md
  • compose/dev/kepler-dev/etc/kepler/config.yaml
  • hack/config.yaml
  • manifests/k8s/configmap.yaml

@sthaha sthaha force-pushed the fix-server-address branch from 91a97e3 to 7eeaf20 Compare July 8, 2025 13:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

⚠️ Config changes detected in this PR.
Please make sure that the config changes are updated in the following places as part of this PR:

  • docs/configuration/configuration.md
  • compose/dev/kepler-dev/etc/kepler/config.yaml
  • hack/config.yaml
  • manifests/k8s/configmap.yaml

SamYuan1990
SamYuan1990 previously requested changes Jul 8, 2025
View reviewed changes
Copy link
Collaborator

@SamYuan1990 SamYuan1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait a min.... listen address is a part of webconfig, so #2165 works or not?

@sthaha
feat(config): add configurable web server listen addresses
c9d7667 
Add support for configurable listen addresses for the web server through
both CLI flags and YAML configuration, instead of the hardcoded :28282
default. This change is needed to support a reverse proxy (kube-rbac-proxy)
setup where the listen-address will use 127.0.0.1:28282 instead of 0.0.0.0:28282

Changes include:
- Add Web.ListenAddresses []string field to config structure
- Add --web.listen-address CLI flag (repeatable for multiple addresses)

Signed-off-by: Sunil Thaha <sthaha@redhat.com>
@sthaha sthaha force-pushed the fix-server-address branch from 7eeaf20 to c9d7667 Compare July 8, 2025 14:08
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

⚠️ Config changes detected in this PR.
Please make sure that the config changes are updated in the following places as part of this PR:

  • docs/configuration/configuration.md
  • compose/dev/kepler-dev/etc/kepler/config.yaml
  • hack/config.yaml
  • manifests/k8s/configmap.yaml

@sthaha sthaha requested a review from SamYuan1990 July 8, 2025 14:11
@sthaha
Copy link
Collaborator Author

sthaha commented Jul 8, 2025 •
edited
Loading

@SamYuan1990

wait a min.... listen address is a part of webconfig, so #2165 works or not?

#2165 PR isn't complete and makes lots of changes unrelated to adding --web.config.file and --web.listen-address. We can revisit that PR once this merges. This pr is required for a critical feature related to securing kepler and make minimal change need to add --web.listen-address. This shouldn't block #2165 from progressing.

@sthaha sthaha marked this pull request as ready for review July 8, 2025 14:16
@sthaha sthaha dismissed SamYuan1990’s stale review July 8, 2025 14:27

Lets discussion implementation of #2165 in that pr. Merging this should not stop that PR from progressing.

@vprashar2929 vprashar2929 merged commit d9d383c into sustainable-computing-io:reboot Jul 8, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vprashar2929 vprashar2929 vprashar2929 approved these changes

@SamYuan1990 SamYuan1990 Awaiting requested review from SamYuan1990

Assignees
No one assigned
Labels
feat A new feature or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sthaha @SamYuan1990 @vprashar2929