feat(monitor): add configurable limit for terminated workloads tracking #2199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## reboot #2199 +/- ##
==========================================
- Coverage 92.39% 92.32% -0.07%
==========================================
Files 38 38
Lines 3907 3924 +17
==========================================
+ Hits 3610 3623 +13
- Misses 236 240 +4
Partials 61 61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8a4fcd5 to
d80bdcc
Compare
|
|
Add new configuration option 'maxTerminated' to control the maximum number of terminated workloads (processes, containers, VMs, pods) kept in memory until exported. This prevents unbounded memory growth in high-churn environments. Changes include: - Add Monitor.MaxTerminated field with default value of 500 - Add --monitor.max-terminated CLI flag for runtime configuration - Add YAML configuration support for maxTerminated setting - Add validation to ensure maxTerminated is non-negative (0 = unlimited) - Update documentation with usage examples and configuration details - Pass maxTerminated parameter to PowerMonitor via WithMaxTerminated option Signed-off-by: Sunil Thaha <sthaha@redhat.com>
d80bdcc to
2fbc24f
Compare
|
|
vimalk78
approved these changes
Jul 3, 2025
b611eea
into
sustainable-computing-io:reboot
19 of 21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new configuration option 'maxTerminated' to control the maximum number of terminated workloads (processes, containers, VMs, pods) kept in memory until exported. This prevents unbounded memory growth in high-churn environments.
Changes include: