refactor(resource): split Refresh into smaller functions with parallel execution #2170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l execution This change breaks down the Refresh method into smaller functions following Single Responsibility Principle. Changes are .. - refreshProcesses: categorizes processes during initial scan - refreshContainers/refreshVMs: build workload-specific collections - refreshPods: handles container-to-pod mapping (depends on containers) - refreshNode: calculates node-level aggregations Note that this change introduces parallel execution using goroutines for independent workloads (containers+pods, VMs, and node calculations) while maintaining proper dependency ordering. Also adds test coverage for concurrency testing, missing coverage and error handling scenarios. Signed-off-by: Sunil Thaha <sthaha@redhat.com>
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Refresh method of the resource informer into focused functions that handle processes, containers, VMs, pods, and node updates independently while using parallel execution to improve performance. Key changes include splitting the refresh logic into granular helper functions and introducing goroutines for concurrent execution, as well as expanding unit test coverage for various refresh scenarios.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/resource/vm_test.go | Added tests for VM ID extraction and VM name extraction functions. |
| internal/resource/procfs_reader_test.go | Enhanced and additional tests covering informer initialization and error handling. |
| internal/resource/pod_test.go | Introduced tests for Pod cloning functionality. |
| internal/resource/informer.go | Refactored refresh logic by splitting into multiple functions and using parallel execution. |
Comments suppressed due to low confidence (2)
internal/resource/informer.go:297
- The variable 'pod' is referenced but not defined; it seems likely that 'cntrInfo.PodID' should be used instead. Please update the code to reference the correct pod identifier.
pod := &Pod{
internal/resource/informer.go:290
- The 'resetCPUTime' variable is declared inside the if-else blocks, limiting its scope. Declare 'resetCPUTime' before the conditional block so it can be used when updating the pod cache.
}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## reboot #2170 +/- ##
==========================================
+ Coverage 91.40% 92.28% +0.87%
==========================================
Files 36 36
Lines 3491 3551 +60
==========================================
+ Hits 3191 3277 +86
+ Misses 232 212 -20
+ Partials 68 62 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vimalk78
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change breaks down the Refresh method into smaller functions following Single Responsibility Principle. Changes are ..
Note that this change introduces parallel execution using goroutines for independent workloads (containers+pods, VMs, and node calculations) while maintaining proper dependency ordering.
Also adds test coverage for concurrency testing, missing coverage and error handling scenarios.