fix(exporter): move WithNodeName option to collector #2150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## reboot #2150 +/- ##
==========================================
- Coverage 91.47% 91.35% -0.12%
==========================================
Files 36 36
Lines 3472 3472
==========================================
- Hits 3176 3172 -4
- Misses 229 232 +3
- Partials 67 68 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sthaha
reviewed
Jun 13, 2025
Comment on lines
+333
to
+345
| for _, metric := range metrics { | ||
| if metric.GetName() == "kepler_process_cpu_joules_total" { | ||
| for _, m := range metric.GetMetric() { | ||
| nodeName := valueOfLabel(m, "node_name") | ||
| assert.Equal(t, "test-node", nodeName, "Process metrics should have node_name label") | ||
| } | ||
| } | ||
| if metric.GetName() == "kepler_process_cpu_watts" { | ||
| for _, m := range metric.GetMetric() { | ||
| nodeName := valueOfLabel(m, "node_name") | ||
| assert.Equal(t, "test-node", nodeName, "Process metrics should have node_name label") | ||
| } | ||
| } |
There was a problem hiding this comment.
suggestion: refactor this into a helper function that assert that assertMetricLabelValue(t, name, label, value) we have something similar called asserrtMainMetricValue which I think can be replaced as well.
sthaha
reviewed
Jun 13, 2025
| @@ -197,6 +197,7 @@ func createPrometheusExporter(logger *slog.Logger, cfg *config.Config, apiServer | |||
| pm, | |||
| prometheus.WithLogger(logger), | |||
| prometheus.WithProcFSPath(cfg.Host.ProcFS), | |||
| prometheus.WithNodeName(cfg.Kube.Node), | |||
sthaha
reviewed
Jun 13, 2025
Moved WithNodeName() option from prometheus exporter to collector
Added tests
Signed-off-by: Vimal Kumar <vimal78@gmail.com>
sthaha
approved these changes
Jun 13, 2025
101a55d
into
sustainable-computing-io:reboot
16 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved WithNodeName() option from prometheus exporter to collector
added tests