fix(monitor): use value-based maps to fix Clone() shallow copy bug #2143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## reboot #2143 +/- ##
==========================================
- Coverage 81.76% 81.59% -0.18%
==========================================
Files 37 37
Lines 3861 3846 -15
==========================================
- Hits 3157 3138 -19
- Misses 630 633 +3
- Partials 74 75 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
440bbf7 to
8f10d05
Compare
8f10d05 to
0589360
Compare
Changes ZoneUsageMap from map[EnergyZone]*Usage to map[EnergyZone]Usage
to eliminate shallow copy issues in Clone() methods.
The original pointer-based maps caused Clone() methods to share Usage
struct pointers between original and cloned objects. Modifying energy/
power values in a cloned object would unintentionally affect the
original object.
Changes:
- Change ZoneUsageMap type definition from map[EnergyZone]*Usage to map[EnergyZone]Usage
- Update Usage struct assignments from &Usage{} to Usage{} in:
Signed-off-by: Sunil Thaha <sthaha@redhat.com>
0589360 to
94aa157
Compare
vimalk78
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes ZoneUsageMap from map[EnergyZone]*Usage to map[EnergyZone]Usage to eliminate shallow copy issues in Clone() methods. The Clone method itself is simpler and use value copy to copy
the non pointers there by eliminating the issue of forgetting to copy a member varible.
The original pointer-based maps caused Clone() methods to share Usage struct pointers between original and cloned objects. Modifying energy/ power values in a cloned object would unintentionally affect the original object.
Changes: