Skip to content

feat(node): add node_name to power metrics #2148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

feat(node): add node_name to power metrics #2148

merged 1 commit into from
Jun 12, 2025

Conversation

vimalk78
Copy link
Collaborator

@vimalk78 vimalk78 commented Jun 12, 2025 •
edited
Loading

  • add node_name label to power metrics
  • updated metric docs

@github-actions github-actions bot added the feat A new feature or enhancement label Jun 12, 2025
@vimalk78 vimalk78 force-pushed the add-node-name-to-metrics branch 2 times, most recently from e4ca0e5 to c49c32a Compare June 12, 2025 12:40
@codecov Codecov
Copy link

codecov bot commented Jun 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.98246% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.35%. Comparing base (4d24510) to head (4e120f7).

Files with missing lines Patch % Lines
internal/exporter/prometheus/prometheus.go 20.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           reboot    #2148      +/-   ##
==========================================
- Coverage   91.52%   91.35%   -0.17%     
==========================================
  Files          36       36              
  Lines        3444     3472      +28     
==========================================
+ Hits         3152     3172      +20     
- Misses        225      232       +7     
- Partials       67       68       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vimalk78 vimalk78 force-pushed the add-node-name-to-metrics branch from c49c32a to 998efa3 Compare June 12, 2025 13:18
@github-actions github-actions bot removed the feat A new feature or enhancement label Jun 12, 2025
@vimalk78 vimalk78 force-pushed the add-node-name-to-metrics branch 5 times, most recently from d4f56a0 to 7db0575 Compare June 12, 2025 13:40
@vimalk78
feat(node): add node_name to power metrics
4e120f7 
Signed-off-by: Vimal Kumar <vimal78@gmail.com>
@vimalk78 vimalk78 force-pushed the add-node-name-to-metrics branch from 7db0575 to 4e120f7 Compare June 12, 2025 13:53
@github-actions github-actions bot added the feat A new feature or enhancement label Jun 12, 2025
@sthaha sthaha merged commit 229c8c0 into sustainable-computing-io:reboot Jun 12, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sthaha sthaha sthaha approved these changes

Assignees
No one assigned
Labels
feat A new feature or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vimalk78 @sthaha