Skip to content

Conversation

vprashar2929
Copy link
Collaborator

This commit adds a tool for generating docs for metrics.

The tool extracts the metrics information from the various prometheus collectors and generates a markdown file with the metrics information.

This is useful for generating the metrics documentation for the kepler

This commit adds a tool for generating docs for metrics.

The tool extracts the metrics information from the various prometheus
collectors and generates a markdown file with the metrics information.

This is useful for generating the metrics documentation for the kepler

Signed-off-by: vprashar2929 <vibhu.sharma2929@gmail.com>
@github-actions github-actions bot added the docs Documentation changes label Jun 8, 2025
Copy link

codecov bot commented Jun 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 212 lines in your changes missing coverage. Please review.

Project coverage is 86.22%. Comparing base (11f34cd) to head (27707be).
Report is 2 commits behind head on reboot.

Files with missing lines Patch % Lines
hack/gen-metric-docs/main.go 0.00% 212 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           reboot    #2133      +/-   ##
==========================================
- Coverage   92.80%   86.22%   -6.58%     
==========================================
  Files          33       34       +1     
  Lines        2779     2991     +212     
==========================================
  Hits         2579     2579              
- Misses        157      369     +212     
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -1,4 +1,4 @@
.PHONY: all build build-debug clean test coverage lint vet fmt deps image push run
.PHONY: all build build-debug clean test coverage lint vet fmt deps image push run deploy undeploy cluster-restart cluster-down cluster-up gen-metrics-docs
Copy link
Collaborator

@sthaha sthaha Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this can we please have multiple .PHONY close to the target so that when you are deleting a target, the .PHONY gets removed as well ? -- In a separate PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

// SPDX-FileCopyrightText: 2025 The Kepler Authors
// SPDX-License-Identifier: Apache-2.0

package main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
Could we write tests as well (in a separate PR) :) so that when we make a change, we don't break doc generation by mistake?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes will do that

Copy link
Collaborator

@sthaha sthaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vprashar2929 Good idea!!

Can we please add a CI test to ensure that the doc is up to date?

@sthaha sthaha merged commit 36ecc29 into sustainable-computing-io:reboot Jun 9, 2025
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants