feat!(metrics): simplify power metrics by consolidating zone-based metrics #2105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfcc7c4 to
8141311
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## reboot #2105 +/- ##
==========================================
- Coverage 92.22% 92.10% -0.13%
==========================================
Files 30 30
Lines 2226 2140 -86
==========================================
- Hits 2053 1971 -82
- Misses 131 134 +3
+ Partials 42 35 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…trics
The new approach simplifies metric naming by consolidating zone-based metrics
generated dynamically with static CPU (device) specific ones with zone labels.
This reduces cardinality, improving queryability, and minimizes runtime complexity.
Changes:
- Replaced dynamic zone-based metric descriptors with static CPU (device) specific descriptors.
E.g. `kepler_node_package_joules_total` -> `kepler_node_package_joules_total{zone="package"}`
- Consolidated metrics under `kepler_<level>_cpu_<unit>` with zone labels
- Removed `kepler_node_energy_zone` metric as it is no longer required.
- Added helper functions for descriptor creation
- Use consistent label names for "zone", "container_id" to ease with
writing queries.
Signed-off-by: Sunil Thaha <sthaha@redhat.com>
8141311 to
817785f
Compare
Signed-off-by: Sunil Thaha <sthaha@redhat.com>
vprashar2929
approved these changes
May 28, 2025
|
Tested against OpenShift: Comparison between reboot v0.0.6 vs dev |
vimalk78
approved these changes
May 28, 2025
| "instant": false, | ||
| "legendFormat": "Kepler Reboot Node (${zones})", | ||
| "legendFormat": "Kepler Reboot Node (${zone}) (ΔJ/s)", |
| "kepler_node_package_joules_total", | ||
| "kepler_node_package_watts", | ||
| "kepler_node_dram_joules_total", | ||
| "kepler_node_dram_watts", | ||
| "kepler_node_energy_zone", | ||
| "kepler_node_cpu_joules_total", | ||
| "kepler_node_cpu_watts", |
There was a problem hiding this comment.
need more tests for zone name assertions?
3d01253
into
sustainable-computing-io:reboot
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new approach simplifies metric naming by consolidating zone-based metrics generated dynamically with static CPU (device) specific ones with zone labels.
Pros:
label_replacehacks to query by selected zones as zone is now a label.Validates if the sum of process watts in container for is the same as the container's power use for each available zone
kepler_node_cpu_core|package_Changes:
Replaced dynamic zone-based metric descriptors with static CPU (device) specific descriptors. E.g.
kepler_node_package_joules_total->kepler_node_cpu_joules_total{zone="package"}Consolidated metrics under
kepler_<level>_cpu_<unit>with zone labelsRemoved
kepler_node_energy_zonemetric as it is no longer required.Added helper functions for descriptor creation
Use consistent label names for "zone", "container_id" to ease with writing queries.