Add PropertyResolverMetadataAwareInterface #8094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84d7265 to
08ed6f4
Compare
packages/content/src/Application/PropertyResolver/PropertyResolverProvider.php
Outdated
Show resolved
Hide resolved
9529426 to
0ea5d17
Compare
# Conflicts: # src/Sulu/Bundle/MediaBundle/Tests/Unit/Infrastructure/Sulu/Content/PropertyResolver/ImageMapPropertyResolverTest.php
0ea5d17 to
ab11b56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adds the PropertyResolverMetadataAwareInterface.
Why?
The BlockPropertyResolver and ImageMapPropertyResolver need the metadata to dynamically resolve the properties. PropertyResolver that do not need the Metadata should not have them in the "params" array, so that they will not be forwarded to the FE.