Remove Website and DefaultController action #8073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ec00a7 to
26eb0c6
Compare
288db29 to
f314fde
Compare
There was a problem hiding this comment.
@Prokyonn added a ToDo for the Segment part here we should readd functional test for it when implemented
1 task
367535e to
668dec0
Compare
Comment on lines
-40
to
-62
| public function testPage406ForNotExistFormat(): void | ||
| { | ||
| $this->client->request('GET', 'http://sulu.lo/.xml'); | ||
|
|
||
| $response = $this->client->getResponse(); | ||
| $this->assertHttpStatusCode(406, $response); | ||
| } | ||
|
|
||
| public function testPageClientAcceptHeaderNotUsed(): void | ||
| { | ||
| $this->client->request('GET', 'http://sulu.lo/', [], [], [ | ||
| 'HTTP_ACCEPT' => 'text/plain', | ||
| ]); | ||
|
|
||
| $response = $this->client->getResponse(); | ||
| $this->assertHttpStatusCode(200, $response); | ||
|
|
||
| // The accept header need to ignore so the http cache will have the correct content type in it | ||
| $this->assertStringStartsWith( | ||
| 'text/html', | ||
| $response->headers->get('Content-Type') | ||
| ); | ||
| } |
There was a problem hiding this comment.
Copied this tests to our ExampleControllerTest maybe in future better move into own ContentControllerTest but better this way as it got not lost.
| use Twig\Environment; | ||
| use Twig\Loader\FilesystemLoader; | ||
|
|
||
| class DefaultControllerTest extends TestCase |
There was a problem hiding this comment.
unnecessary tests as too much mocks and no new behaviour tests as where functional tested in WebsiteControllerTests and now new functional tests via ExampleControllerTest
8cb257c to
c572334
Compare
| use Symfony\Bundle\FrameworkBundle\KernelBrowser; | ||
|
|
||
| #[\PHPUnit\Framework\Attributes\RunTestsInSeparateProcesses] | ||
| class SecurityListenerTest extends SuluTestCase |
There was a problem hiding this comment.
Added it to our ToDo that we recreate similar tests based on new content storage
Prokyonn
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Remove Website and DefaultController action.
Why?
The content bundle does provide the new website controller for content resolving. All usage of the old DefaultController or WebsiteController should now use the
Sulu\Content\UserInterface\Controller\Website\ContentControllerinstead.