Add Versioning to the ContentBundle #8054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prokyonn
commented
Jul 18, 2025
| @@ -51,7 +51,7 @@ public function removeLegacyPageAdmin(ContainerBuilder $container): void | |||
| $definition = $methodCall[1][0]; | |||
| if ($definition instanceof Definition) { | |||
| $class = $definition->getClass(); | |||
| if ('%sulu_page.admin.class%' === $class) { | |||
| if ('Sulu\Bundle\PageBundle\Admin\PageAdmin' === $class) { | |||
There was a problem hiding this comment.
This was overseen when removing the class parameters
Prokyonn
commented
Jul 18, 2025
packages/page/assets/js/views/List/itemActions/RestoreVersionItemAction.js
Show resolved
Hide resolved
...undle/AdminBundle/Resources/js/containers/List/fieldTransformers/DateTimeFieldTransformer.js
Outdated
Show resolved
Hide resolved
Prokyonn
commented
Jul 18, 2025
packages/content/src/Application/ContentWorkflow/Subscriber/PublishTransitionSubscriber.php
Outdated
Show resolved
Hide resolved
packages/page/src/Infrastructure/Symfony/HttpKernel/SuluPageBundle.php
Outdated
Show resolved
Hide resolved
e95e4e5 to
76aa519
Compare
04b4816 to
77b63f9
Compare
|
as discussed I would backport the JS changes to 2.6 branch :) |
see #8060 I'll revert it in this branch as soon as the other MR is merged into the 3.0 branch :) |
1470f4c to
1e10e69
Compare
| @@ -21,6 +21,8 @@ interface DimensionContentInterface | |||
| public const STAGE_DRAFT = 'draft'; | |||
| public const STAGE_LIVE = 'live'; | |||
|
|
|||
| public const DEFAULT_VERSION = 0; | |||
There was a problem hiding this comment.
Suggested change
| public const DEFAULT_VERSION = 0; | |
| public const CURRENT_VERSION = 0; |
| @@ -40,6 +40,8 @@ trait DimensionContentTrait | |||
| */ | |||
| private $isMerged = false; | |||
|
|
|||
| private int $version = DimensionContentInterface::DEFAULT_VERSION; | |||
There was a problem hiding this comment.
Suggested change
| private int $version = DimensionContentInterface::DEFAULT_VERSION; | |
| private int $version = DimensionContentInterface::CURRENT_VERSION; |
| public static function getDefaultDimensionAttributes(): array | ||
| { | ||
| return [ | ||
| 'locale' => null, | ||
| 'stage' => DimensionContentInterface::STAGE_DRAFT, | ||
| 'version' => DimensionContentInterface::DEFAULT_VERSION, |
There was a problem hiding this comment.
Suggested change
| 'version' => DimensionContentInterface::DEFAULT_VERSION, | |
| 'version' => DimensionContentInterface::CURRENT_VERSION, |
| SecurityCheckerInterface $securityChecker, | ||
| array $settingsForms | ||
| private ViewBuilderFactoryInterface $viewBuilderFactory, | ||
| private ActivityViewBuilderFactoryInterface $activityViewBuilderFactory, |
There was a problem hiding this comment.
didn't we say its responsoble of page, article and snippet admin to add activity to the insights? and content bundle doesnt know about the activities?
1e10e69 to
e462520
Compare
# Conflicts: # packages/content/src/Infrastructure/Doctrine/DimensionContentQueryEnhancer.php # Conflicts: # packages/page/src/Domain/Model/PageDimensionContent.php # packages/page/src/Domain/Model/PageDimensionContentInterface.php
# Conflicts: # packages/article/src/Domain/Model/ArticleDimensionContentInterface.php # src/Sulu/Bundle/AdminBundle/Resources/js/containers/List/fieldTransformers/DateTimeFieldTransformer.js
e462520 to
bcfd5a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adds Versioning to content-bundle entities
Why?
To Do