Skip to content

Deprecating the AddMetadataProviderPass #8038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 2.6
Choose a base branch
from
Open

Deprecating the AddMetadataProviderPass #8038

wants to merge 1 commit into from

Conversation

mamazu
Copy link
Contributor

@mamazu mamazu commented Jul 6, 2025

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Fixed tickets -
Related issues/PRs #7402
License MIT
Documentation PR -

What's in this PR?

Deprecating AddMetadataProviderPass and suggesting the tagged_locator instead.

Why?

  • Symfony already has this feature.
  • As far as I know the locator also only loads the services when they're actually used, so maybe also a performance thing?

Example Usage

<service id="Sulu\Bundle\AdminBundle\Metadata\MetadataProviderRegistry">
    <argument type="tagged_locator" tag="sulu_admin.metadata_provider" index-by="type" />
</service>

@mamazu mamazu mentioned this pull request Jul 4, 2025
Open
16 tasks
@mamazu mamazu added Technical Debt Impacts code quality, no or just small impact on end developers and users DX Affecting the end developer labels Jul 6, 2025
@mamazu mamazu force-pushed the tagged_locator_in_metadata_registry branch from aaaf6e2 to 987add6 Compare July 6, 2025 14:10
@mamazu mamazu force-pushed the tagged_locator_in_metadata_registry branch from 987add6 to 62e70a2 Compare July 6, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DX Affecting the end developer Technical Debt Impacts code quality, no or just small impact on end developers and users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mamazu