Skip to content

Deprecate the LocalizationProviderCompilerPass #8035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 2.6
Choose a base branch
from
Open

Deprecate the LocalizationProviderCompilerPass #8035

wants to merge 1 commit into from

Conversation

mamazu
Copy link
Contributor

@mamazu mamazu commented Jul 4, 2025 •
edited
Loading

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Fixed tickets -
Related issues/PRs #7402
License MIT
Documentation PR sulu/sulu-docs#

What's in this PR?

Deprecating the RegisterLocalizationProvidersPass so that we can remove it in 3.0

Why?

Symfony already implements this behaviour which is much more convenient.

Example Usage

<service id="sulu.core.localization_manager" 
    class="Sulu\Component\Localization\Manager\LocalizationManager" 
    public="true"
>
    <argument type="tagged_iterator" tag="sulu.localization_provider" />
</service>

mamazu
mamazu commented Jul 4, 2025
View reviewed changes
src/Sulu/Component/Localization/Manager/LocalizationManagerInterface.php
Comment on lines +33 to +35
/**
* @deprecated since Use the constructor instead
*/
Copy link
Contributor Author

@mamazu mamazu Jul 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this is deprecated and removed the LocalizationManagerInterface and the LocalizationProviderInterface are the same (just different method names). So I would suggest deprecating the entire interface and using the LocalizationProviderInterface everywhere.

mamazu
mamazu commented Jul 4, 2025
View reviewed changes
Copy link
Contributor Author

@mamazu mamazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@mamazu mamazu mentioned this pull request Jul 3, 2025
Open
16 tasks
@mamazu mamazu added Technical Debt Impacts code quality, no or just small impact on end developers and users DX Affecting the end developer labels Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DX Affecting the end developer Technical Debt Impacts code quality, no or just small impact on end developers and users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mamazu