Add SmartContent support for Sulu 3.0 #8032
Merged
+5,436
−11,528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachterjohannes
requested changes
Jun 30, 2025
There was a problem hiding this comment.
@Prokyonn Code looks very good - remove all the strict-types but the rest is good
packages/article/src/Infrastructure/Doctrine/Repository/ArticleRepository.php
Outdated
Show resolved
Hide resolved
packages/content/src/Application/PropertyResolver/Resolver/SmartContentPropertyResolver.php
Outdated
Show resolved
Hide resolved
packages/content/src/Application/SmartResolver/Resolver/SmartContentSmartResolver.php
Outdated
Show resolved
Hide resolved
aa0bb86 to
2f09402
Compare
packages/content/src/Application/PropertyResolver/Resolver/SmartContentPropertyResolver.php
Outdated
Show resolved
Hide resolved
packages/content/src/Application/PropertyResolver/Resolver/SmartContentPropertyResolver.php
Outdated
Show resolved
Hide resolved
packages/content/src/Application/PropertyResolver/Resolver/SmartContentPropertyResolver.php
Outdated
Show resolved
Hide resolved
packages/content/src/Application/PropertyResolver/Resolver/SmartContentPropertyResolver.php
Outdated
Show resolved
Hide resolved
1dbcd8b to
6d72323
Compare
7a4fb47 to
b0351a3
Compare
packages/article/src/Infrastructure/Sulu/Content/ArticleSmartContentProvider.php
Outdated
Show resolved
Hide resolved
packages/article/src/Infrastructure/Sulu/Content/ArticleSmartContentProvider.php
Outdated
Show resolved
Hide resolved
alexander-schranz
requested changes
Jul 15, 2025
packages/content/src/Application/ContentResolver/Value/ResolvableInterface.php
Show resolved
Hide resolved
packages/content/src/Infrastructure/Doctrine/JoinFilterTrait.php
Outdated
Show resolved
Hide resolved
packages/page/src/Infrastructure/Sulu/Content/PageSmartContentProvider.php
Outdated
Show resolved
Hide resolved
src/Sulu/Bundle/AdminBundle/Metadata/FormMetadata/OptionMetadata.php
Outdated
Show resolved
Hide resolved
src/Sulu/Bundle/AdminBundle/Metadata/FormMetadata/OptionMetadata.php
Outdated
Show resolved
Hide resolved
src/Sulu/Bundle/AdminBundle/Metadata/FormMetadata/OptionMetadata.php
Outdated
Show resolved
Hide resolved
...undle/ContactBundle/Infrastructure/Sulu/Content/SmartContent/AccountSmartContentProvider.php
Outdated
Show resolved
Hide resolved
packages/content/src/Application/Visitor/SmartContentFiltersVisitorInterface.php
Show resolved
Hide resolved
|
Looks fine, we may should recheck where to add final and readonly keywords, but that own PRs added it to our content storage checklist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adds support for SmartContents in the new content storage architecture for Sulu 3.0
Implements the DataProvider for
Why?
Add SmartContent functionality for 3.0
Example Usage
To Do