Skip to content

Use property types for the DomainEvent #8023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

Use property types for the DomainEvent #8023

merged 1 commit into from
Jul 16, 2025

Conversation

mamazu
Copy link
Contributor

@mamazu mamazu commented Jun 19, 2025 •
edited
Loading

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets -
Related issues/PRs -
License MIT
Documentation PR -

What's in this PR?

Using property types as the properties are private and the getter and setters are strictly typed.

Why?

  • For a strictly typed Sulu future
  • Phpstan will complain if the types of the getters/setter not match the property types.
  • Giving explicit default values (good that we have tests that caught that)

@mamazu mamazu changed the title Tighening types for event bundle Using property types for the =DomainEvent` Jun 19, 2025
@mamazu mamazu changed the title Using property types for the =DomainEvent` Using property types for the DomainEvent Jun 19, 2025
@mamazu mamazu added Technical Debt Impacts code quality, no or just small impact on end developers and users DX Affecting the end developer labels Jun 19, 2025
@alexander-schranz alexander-schranz merged commit 73fd9ed into sulu:2.5 Jul 16, 2025
8 of 9 checks passed
@alexander-schranz alexander-schranz changed the title Using property types for the DomainEvent Use property types for the DomainEvent Jul 16, 2025
@mamazu mamazu deleted the event_types branch July 16, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-schranz alexander-schranz alexander-schranz approved these changes

Assignees
No one assigned
Labels
DX Affecting the end developer Technical Debt Impacts code quality, no or just small impact on end developers and users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mamazu @alexander-schranz