Skip to content

Ignore keys in FOSJSRoutingControllerTest #8014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Jun 10, 2025

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #
Related issues/PRs #
License MIT
Documentation PR sulu/sulu-docs#

What's in this PR?

Ignore keys in FOSJSRoutingControllerTest.

Why?

This test was kind of hard to debug if something was missing.

Before:

Bildschirmfoto 2025-06-10 um 13 52 31

After:

Bildschirmfoto 2025-06-10 um 13 50 49

@alexander-schranz alexander-schranz added the DX Affecting the end developer label Jun 10, 2025
@mamazu
Copy link
Contributor

mamazu commented Jun 10, 2025

You could also use array_diff:

$this->assertEmpty(array_diff($existingRoutes, $currentRoutes), 'Missing routes');
$this->assertEmpty(array_diff($currentRoutes, $existingRoutes), 'New routes, that were not there before');

@alexander-schranz alexander-schranz merged commit a850a2d into sulu:2.6 Jun 10, 2025
9 checks passed
@alexander-schranz alexander-schranz deleted the enhancement/fos-js-routing-controller-test branch June 10, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Affecting the end developer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants