Fixed deprecation happening when content type is checked in AppendAnalyticsListener #7186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stollr nice catch, can you rebase it to the 2.4 as there the deprecation should also be removed. |
fda2ace to
64aac0d
Compare
|
@alexander-schranz done ;-) |
…t type This is required, because the content type can be null (for example for responses with status code 204), which results in 'strpos(): Passing null to parameter sulu#1 () of type string is deprecated' in PHP 8.2
64aac0d to
8f34e73
Compare
|
@stollr Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Setting default value in AppendAnalyticsListener when checking content type.
Why?
This is required, because the content type can be null (for example for responses with status code
204), which results in the following deprecation message:in PHP 8.2
Example Usage
Add the following return statement to a controller action to reproduce the issue: