Fix incompatibility to Symfony 6.4 renderBlock method #7148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fix incompatibility to Symfony 6.4 renderBlock method.
Why?
Symfony introduced its own
renderBlock
method and we need to migrate to the compatiblerenderBlockView
method.Upgrade
Actually the upgrade here is hard, from Sulu side it would be.
but this would manipulate all
renderBlock
methods and rector rules should work always. So in this case we would need a custom rule which checks if the result of renderBlock/renderBlockView is used as a string or response.So that is the hard case here to create automatic upgrade 🤔 . Inheritance make things always harder then composition.