Fix profiler tab with new content structure #7999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamazu
commented
Jun 7, 2025
mamazu
commented
Jun 7, 2025
| {{ self.table_row('class', collector.data('structure').objectClass) }} | ||
| {{ self.table_row('path', collector.data('structure').path) }} | ||
| {{ self.table_row('nodeType', collector.data('structure').nodeType) }} | ||
| {{ self.table_row('internal', collector.data('structure').internal ? 'yes' : 'no') }} |
There was a problem hiding this comment.
Is there already something like "internal" in the new system?
f60653a to
d2d35c0
Compare
|
@Prokyonn You're the expert on the new content structure. Can you have a look at this and tell me if this migration is correct? |
Prokyonn
requested changes
Jul 1, 2025
| $structureObject = $params['structure']; | ||
| if ($request->attributes->has('object')) { | ||
| $object = $request->attributes->get('object'); | ||
| if ($object instanceof PageDimensionContent) { |
There was a problem hiding this comment.
I think we should make it more flexible, so that it works also for custom content-bundle entities.
So we should check the interfaces individually, e.g.
instanceof WorkflowInterface --> getWorkflowPublished
instanceof ShadowInterface --> shadowLocales
instanceof WebspaceInterface --> webspace
instanceof TemplateInterface --> template
....
There was a problem hiding this comment.
Yes makes sense. I did that. Can you check if it's modular enough?
5843427 to
af31254
Compare
Prokyonn
requested changes
Jul 3, 2025
1e6aa85 to
a701d8f
Compare
Prokyonn
approved these changes
Jul 16, 2025
alexander-schranz
approved these changes
Jul 16, 2025
|
@mamazu Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Updating the profiler bar to use the new content entity.
Why?
Otherwise the profiler bar will just be empty.