Skip to content

[WIP] Say goodbye to the old phpcr, document manager, page bundle services 🫡 #7995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: 3.0
Choose a base branch
from
Draft

[WIP] Say goodbye to the old phpcr, document manager, page bundle services 🫡 #7995

wants to merge 2 commits into from

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Jun 6, 2025 •
edited
Loading

Q A
Bug fix? no
New feature? no
BC breaks? MANY say goodbye to phpcr, document manager they served us well 🫡
Deprecations? yes
Fixed tickets fixes #
Related issues/PRs #
License MIT
Documentation PR sulu/sulu-docs#

What's in this PR?

Remove step by step old services and find usages of them in unrelated cases.

Why?

Replacing PHPCR and so the document manager with the new content storage is target of 3.0. By already replace the old structure metadata usage in most places we can now step by step go to replace it.

ToDo

Following tests fail without PHPCR related services:

  • article
  • content
  • page
  • route
  • snippet
  • ActivityBundle
  • AdminBundle
  • AudienceTargetingBundle
  • CategoryBundle
  • ContactBundle
  • CoreBundle
  • HttpCacheBundle
  • LocationBundle
  • MarkupBundle
  • MediaBundle
  • PersistenceBundle
  • PreviewBundle
  • ReferenceBundle
  • RouteBundle (will be removed)
  • SecurityBundle
  • TagBundle
  • TrashBundle
  • WebsiteBundle
  • Components

Other todos:

  • Remove PHPCR dependencies from composer.json
  • Remove unused component classes

@alexander-schranz alexander-schranz added Technical Debt Impacts code quality, no or just small impact on end developers and users DX Affecting the end developer labels Jun 6, 2025
This was referenced Jun 6, 2025
Merged
Merged
Merged
Merged
@alexander-schranz alexander-schranz force-pushed the enhancement/remove-phpcr-document-manager-based-test-references branch 3 times, most recently from fa6836c to 7ff5873 Compare June 11, 2025 05:28
@alexander-schranz alexander-schranz mentioned this pull request Jun 11, 2025
Merged
@alexander-schranz alexander-schranz force-pushed the enhancement/remove-phpcr-document-manager-based-test-references branch from 7ff5873 to e9ae06a Compare June 11, 2025 07:02
@alexander-schranz alexander-schranz mentioned this pull request Jun 13, 2025
Merged
mamazu
mamazu reviewed Jun 13, 2025
View reviewed changes
@alexander-schranz alexander-schranz force-pushed the enhancement/remove-phpcr-document-manager-based-test-references branch 3 times, most recently from d6899d5 to eb08aa6 Compare June 13, 2025 14:06
@alexander-schranz alexander-schranz force-pushed the enhancement/remove-phpcr-document-manager-based-test-references branch 2 times, most recently from 9505f20 to fb44984 Compare July 25, 2025 11:00
This was referenced Jul 25, 2025
Merged
Merged
@alexander-schranz alexander-schranz force-pushed the enhancement/remove-phpcr-document-manager-based-test-references branch from fb44984 to e406b17 Compare July 25, 2025 11:19
@alexander-schranz alexander-schranz mentioned this pull request Jul 25, 2025
Merged
@alexander-schranz alexander-schranz force-pushed the enhancement/remove-phpcr-document-manager-based-test-references branch from e406b17 to 064df8d Compare July 25, 2025 12:13
@alexander-schranz alexander-schranz mentioned this pull request Jul 25, 2025
Merged
@alexander-schranz alexander-schranz force-pushed the enhancement/remove-phpcr-document-manager-based-test-references branch from 064df8d to 4086202 Compare July 25, 2025 12:42
@alexander-schranz alexander-schranz mentioned this pull request Jul 28, 2025
Merged
@alexander-schranz alexander-schranz force-pushed the enhancement/remove-phpcr-document-manager-based-test-references branch from bca93d5 to a7a008a Compare July 28, 2025 11:34
@alexander-schranz alexander-schranz mentioned this pull request Jul 28, 2025
Merged
@alexander-schranz alexander-schranz force-pushed the enhancement/remove-phpcr-document-manager-based-test-references branch from a7a008a to 6a242a6 Compare July 28, 2025 12:03
@alexander-schranz alexander-schranz mentioned this pull request Jul 28, 2025
Merged
@alexander-schranz alexander-schranz force-pushed the enhancement/remove-phpcr-document-manager-based-test-references branch from 7de8d5d to b312485 Compare August 18, 2025 12:55
@alexander-schranz alexander-schranz mentioned this pull request Aug 18, 2025
Merged
@alexander-schranz alexander-schranz force-pushed the enhancement/remove-phpcr-document-manager-based-test-references branch from b312485 to 9dc16fc Compare August 18, 2025 15:14
This was referenced Aug 18, 2025
Merged
Closed
@alexander-schranz alexander-schranz force-pushed the enhancement/remove-phpcr-document-manager-based-test-references branch from a5b8282 to ba1f4ef Compare August 18, 2025 15:59
This was referenced Aug 19, 2025
Closed
Merged
Merged
@alexander-schranz alexander-schranz force-pushed the enhancement/remove-phpcr-document-manager-based-test-references branch 2 times, most recently from 8819718 to 1bc5862 Compare August 19, 2025 08:44
This was referenced Aug 19, 2025
Merged
Merged
@alexander-schranz alexander-schranz force-pushed the enhancement/remove-phpcr-document-manager-based-test-references branch from 1bc5862 to a968e64 Compare August 19, 2025 08:54
@alexander-schranz alexander-schranz mentioned this pull request Aug 19, 2025
Merged
@alexander-schranz alexander-schranz force-pushed the enhancement/remove-phpcr-document-manager-based-test-references branch from b567f43 to 59b2d2c Compare August 19, 2025 09:10
@alexander-schranz alexander-schranz changed the title [WIP] Say good by to the old phpcr, document manager, page bundle services 🫡 [WIP] Say goodbye to the old phpcr, document manager, page bundle services 🫡 Aug 19, 2025
@alexander-schranz alexander-schranz force-pushed the enhancement/remove-phpcr-document-manager-based-test-references branch from 59b2d2c to 56da0d5 Compare August 19, 2025 09:15
@alexander-schranz alexander-schranz mentioned this pull request Aug 19, 2025
Merged
@alexander-schranz alexander-schranz force-pushed the enhancement/remove-phpcr-document-manager-based-test-references branch from 56da0d5 to 9b99b9f Compare August 19, 2025 11:45
@alexander-schranz alexander-schranz mentioned this pull request Aug 19, 2025
Merged
@alexander-schranz alexander-schranz force-pushed the enhancement/remove-phpcr-document-manager-based-test-references branch from 9b99b9f to c2d76ab Compare August 19, 2025 13:17
@alexander-schranz alexander-schranz mentioned this pull request Aug 19, 2025
Merged
@alexander-schranz alexander-schranz force-pushed the enhancement/remove-phpcr-document-manager-based-test-references branch from c2d76ab to cab8139 Compare August 19, 2025 13:48
@alexander-schranz alexander-schranz mentioned this pull request Aug 19, 2025
Merged
@alexander-schranz alexander-schranz force-pushed the enhancement/remove-phpcr-document-manager-based-test-references branch from cab8139 to 82b7fe9 Compare August 19, 2025 15:02
@alexander-schranz alexander-schranz mentioned this pull request Aug 19, 2025
Merged
@alexander-schranz alexander-schranz force-pushed the enhancement/remove-phpcr-document-manager-based-test-references branch from 82b7fe9 to fbc2216 Compare August 19, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mamazu mamazu mamazu left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
DX Affecting the end developer Technical Debt Impacts code quality, no or just small impact on end developers and users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-schranz @mamazu