What's in this PR?

Replace form metadata name with key.

Why?

Beside the name also a key was introduced in #4643 Pull Request. But seems like this are just two fields.

Currently it is very confusing as seen in a lot of tests where the setName was called with a value which make more sense for setTitle (e.g. setName('Example Template')). It is kind of intransparent here where name and where key is used and its not filled up in all cases correctly.

Both <form> and <template> xml both uses the <key> and as it we personally mostly talk about template or form keys I would go here with getKey and setKey methods over the names. The only case where FormMetadata is created by a name is inside block / image map every <type name="text_block"> is also an own form metadata. Still I would for bc reasons not rename the type attribute name here to key, but internal I would set by the name attribute the form key.

Example Usage

- $formMetadata->getName();
+ $formMetadata->getKey();

To Do

• Add breaking changes to UPGRADE.md